-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder #41
Builder #41
Conversation
Simplify traits to hide private methods
Why did this get closed? |
Oh, I didn't intend to close this PR. Seems this PR was closed because I deleted my branch |
@faassen Sorry, but I didn't notice this PR aimed to be merged to Unfortunately, however, it looks I have no authority to re-open this PR. Is it possible for you to reopen the PR? Maybe we can now recreate the PR toward |
Probably, we can re-open this PR by changing the target (base) branch of this PR. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request |
Ah yes! I will give it a shot |
I'm closing this one again as I found it easier to just create a new PR. |
Here's the builder as I describe it mostly in #40
I've created it as a PR for the
refactor-api-wrapper
branch but it doesn't really depend on it, and we should merge that branch before we do this (without builder in that case).If we decide to go for this I would expose the builder on the top level, and make
new()
andcount_only
constructor methods crate-only, so that the builder is the only way to construct an index.