Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder #41

Closed
wants to merge 4 commits into from
Closed

Builder #41

wants to merge 4 commits into from

Conversation

faassen
Copy link
Collaborator

@faassen faassen commented Jan 22, 2025

Here's the builder as I describe it mostly in #40

I've created it as a PR for the refactor-api-wrapper branch but it doesn't really depend on it, and we should merge that branch before we do this (without builder in that case).

If we decide to go for this I would expose the builder on the top level, and make new() and count_only constructor methods crate-only, so that the builder is the only way to construct an index.

@faassen faassen marked this pull request as draft January 22, 2025 15:37
Simplify traits to hide private methods
@ajalab ajalab deleted the branch ajalab:refactor-api-wrapper January 25, 2025 00:50
@ajalab ajalab closed this Jan 25, 2025
@faassen
Copy link
Collaborator Author

faassen commented Jan 25, 2025

Why did this get closed?

@ajalab
Copy link
Owner

ajalab commented Jan 25, 2025

Oh, I didn't intend to close this PR. Seems this PR was closed because I deleted my branch ajalab:refactor-api-wrapper after merging #36.

@ajalab
Copy link
Owner

ajalab commented Jan 25, 2025

@faassen Sorry, but I didn't notice this PR aimed to be merged to ajalab:refactor-api-wrapper. I recovered the branch just now.

Unfortunately, however, it looks I have no authority to re-open this PR. Is it possible for you to reopen the PR? Maybe we can now recreate the PR toward master instead of refactor-api-wrapper.

@ajalab
Copy link
Owner

ajalab commented Jan 25, 2025

@faassen
Copy link
Collaborator Author

faassen commented Jan 25, 2025

Ah yes! I will give it a shot

@faassen faassen reopened this Jan 25, 2025
@faassen
Copy link
Collaborator Author

faassen commented Jan 25, 2025

I'm closing this one again as I found it easier to just create a new PR.

@faassen faassen closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants