-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple texts #33
Draft
faassen
wants to merge
3
commits into
ajalab:master
Choose a base branch
from
faassen:multi-text
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
multiple texts #33
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
use crate::Character; | ||
|
||
/// A text builder lets you construct a text from multiple parts. | ||
/// Internally each part is separated by the 0 character. | ||
pub struct TextBuilder<T> | ||
where | ||
T: Character, | ||
{ | ||
id_counter: usize, | ||
text: Vec<T>, | ||
} | ||
|
||
/// A unique id identifying this text. | ||
#[derive(Clone, Copy, Debug, Eq, PartialEq, PartialOrd, Ord, Hash)] | ||
pub struct TextId(usize); | ||
|
||
impl<T> TextBuilder<T> | ||
where | ||
T: Character, | ||
{ | ||
/// Create a new empty text builder. | ||
pub fn new() -> TextBuilder<T> { | ||
TextBuilder { | ||
id_counter: 0, | ||
text: vec![], | ||
} | ||
} | ||
|
||
/// Add a text to the builder. | ||
/// | ||
/// Returns a unique id for this text. | ||
fn add_text(&mut self, text: &[T]) -> TextId { | ||
let id = TextId(self.id_counter); | ||
self.id_counter += 1; | ||
self.text.extend_from_slice(text); | ||
self.text.push(T::zero()); | ||
id | ||
} | ||
|
||
/// Finish the build and return the text. | ||
fn build(self) -> Vec<T> { | ||
self.text | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be also an option that we implement new APIs on a new trait/struct such as
MultiTextSearchIndex
that wraps aBackwardIterableIndex
instance.Doc
data to every FM-Index variant likeFMIndex
andRLFMIndex
.SearchIndex
and multi-texts search indexMultiTextSearchIndex
. For instance,locate
query in the former trait may just return pattern positions, whereas the latter may return positions withTextId
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it would be nice to have a search index API that doesn't allow any \0 (or at least one at the end), and a multi index that accepts \0 (or a builder pattern), that offers the extended APIs.
So let's explore this. I'm a still not entirely sure how to implement doc so I hope to get this in a shape so you can help me implement it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! I'll also try to implement the multi-text search based on the APIs you outlined.