Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): fix kafka topic invalid test #684

Merged
merged 1 commit into from
Mar 25, 2024
Merged

chore(tests): fix kafka topic invalid test #684

merged 1 commit into from
Mar 25, 2024

Conversation

byashimov
Copy link
Contributor

  • Fixes kafka topic test
  • Fails tests on error condition

@byashimov
Copy link
Contributor Author

Exits on test error.

    kafkatopic_test.go:96: 
        	Error Trace:	/aiven-operator/tests/kafkatopic_test.go:96
        	Error:      	Received unexpected error:
        	            	409: {"errors":[{"message":"Cannot set local retention when service does not have tiered storage enabled","status":409}],"message":"Cannot set local retention when service does not have tiered storage enabled"} - 
        	Test:       	TestKafkaTopic

@byashimov byashimov mentioned this pull request Mar 25, 2024
Merged
@byashimov
Copy link
Contributor Author

tests

@byashimov byashimov marked this pull request as ready for review March 25, 2024 16:19
@byashimov byashimov requested a review from a team March 25, 2024 16:19
Serpentiel
Serpentiel approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel self-assigned this Mar 25, 2024
@Serpentiel Serpentiel added the enhancement New feature or request label Mar 25, 2024
@Serpentiel Serpentiel merged commit 4460929 into main Mar 25, 2024
41 checks passed
@Serpentiel Serpentiel deleted the byashimov-fix-kafka-topic-test branch March 25, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@Serpentiel Serpentiel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @Serpentiel