Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use compatible client error checks #676

Merged
merged 1 commit into from
Mar 18, 2024
Merged

refactor: use compatible client error checks #676

merged 1 commit into from
Mar 18, 2024

Conversation

byashimov
Copy link
Contributor

Now we are mixing the old and the new client. Error checks must support both types of errors: the old and the new one.

@byashimov byashimov requested a review from a team March 18, 2024 09:30
@byashimov
Copy link
Contributor Author

tests

rriski
rriski approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@rriski rriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byashimov byashimov merged commit 1191335 into main Mar 18, 2024
40 of 41 checks passed
@byashimov byashimov deleted the byashimov-clients-compatible-error-checks branch March 18, 2024 11:23
@Serpentiel Serpentiel added the enhancement New feature or request label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rriski rriski rriski approved these changes

Assignees

@rriski rriski

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byashimov @rriski @Serpentiel