Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKC updates for v2.0 #815

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

AKC updates for v2.0 #815

wants to merge 2 commits into from

Conversation

schristley
Copy link
Member

Consistency issues with the schema file as reported by the AKC project.

@schristley schristley added this to the AKC beta release --> AIRR milestone Nov 26, 2024
@schristley schristley linked an issue Nov 26, 2024 that may be closed by this pull request
15 tasks
@javh
Copy link
Contributor

javh commented Jan 27, 2025

From the call:

  • Good to merge after fixing tests failures.

@bcorrie bcorrie mentioned this pull request Jan 28, 2025
@bcorrie
Copy link
Contributor

bcorrie commented Jan 29, 2025

@williamdlees wanted to confirm that this change is correct...

AlleleDescription.release_version is defined as an integer
GermlineSet.release_version is defined as a number

Is it correct for both of these to be integer?

There are also additions of more info for the Ontology fields that you might want to confirm, but I assume these are correct.

@bcorrie
Copy link
Contributor

bcorrie commented Jan 29, 2025

This pull request closes #813 which has a number of outstanding issues, so this needs more work...

@williamdlees
Copy link
Contributor

I'm OK with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

bugs in airr-schema.yaml / airr-schema-openapi3.yaml
4 participants