Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing airbeam network #3990

Merged
merged 3 commits into from
Dec 3, 2024
Merged

introducing airbeam network #3990

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcb5185
introducing airbeam network
Baalmart Dec 3, 2024
b5459ba
disable network creation
Baalmart Dec 3, 2024
5f36f88
fixing the mappings
Baalmart Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/device-registry/config/global/mappings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ const mappings = {
PREDEFINED_FILTER_VALUES: {
NETWORKS: ["metone", "usembassy"],
COMBINATIONS: {
NETWORK_PAIRS: [["metone", "usembassy"], ["kcca", "clarity"]],
NETWORK_PAIRS: [
["metone", "usembassy", "us_embassy"],
["kcca", "clarity"],
[("urbanbetter", "airbeam", "urban_better")],
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix syntax error in NETWORK_PAIRS array

There's a syntax error in the array definition that needs to be corrected. The parentheses around the last array element are incorrect and will cause unexpected behavior.

Apply this diff to fix the syntax:

  NETWORK_PAIRS: [
    ["metone", "usembassy", "us_embassy"],
    ["kcca", "clarity"],
-   [("urbanbetter", "airbeam", "urban_better")],
+   ["urbanbetter", "airbeam", "urban_better"],
  ],
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
NETWORK_PAIRS: [
["metone", "usembassy", "us_embassy"],
["kcca", "clarity"],
[("urbanbetter", "airbeam", "urban_better")],
],
NETWORK_PAIRS: [
["metone", "usembassy", "us_embassy"],
["kcca", "clarity"],
["urbanbetter", "airbeam", "urban_better"],
],

GROUP_PAIRS: [["metone", "usembassy"], ["kcca", "clarity"]],
STATUS_PAIRS: [
["active", "enabled", "running"],
Expand Down
Loading