-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/integration iqair devices [WIP] #3950
Merged
Baalmart
merged 10 commits into
airqo-platform:staging
from
NicholasTurner23:update/Integration-iqair-devices
Dec 1, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
858a97a
Ground work for extracting devices by networks.
NicholasTurner23 f935b04
Temp cleanup pending extensive data cleanup and checks
NicholasTurner23 de76f5a
Clean up - Renamed for readability and re-usability
NicholasTurner23 3fac8a0
Add the iqair data source to data sources
NicholasTurner23 9b7bde5
Update data validation to apply for specific networks
NicholasTurner23 ee6b837
Add data extraction by networks and dynamic column mapping
NicholasTurner23 0f3f3b1
Retrieve raw data by networks
NicholasTurner23 202f610
Merge branch 'staging' into update/Integration-iqair-devices
NicholasTurner23 dc7fa06
Clean up
NicholasTurner23 80ff39a
Clean up
NicholasTurner23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Avoid using
pop
when extracting values to prevent unintended side effectsUsing
device.pop("site", {}).get(...)
modifies thedevice
dictionary in place, which could lead to unexpected behavior ifdevice
is used elsewhere after this operation. Consider usingdevice.get("site", {}).get(...)
instead to safely access the values without modifying the original dictionary.Apply this diff to replace
pop
withget
:Similarly, review other instances where
pop
is used when extracting values to prevent unintended side effects.📝 Committable suggestion