Ft locate redisgn #1564
Open
Ft locate redisgn #1564
+788
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sserurich
requested review from
uman95,
wabinyai,
Priscilla-AL,
Mnoble-19 and
NsubugaAnold
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+65
to
+68
| return { | ||
| "message": f"missing parameter: {str(err)}. please refer to API documentation for details", | ||
| "success": False, | ||
| }, 400 |
Check warning
Code scanning / CodeQL
Information exposure through an exception
Comment on lines
+70
to
+73
| return { | ||
| "message": f"Some errors occurred: {str(err)}", | ||
| "success": False, | ||
| }, 400 |
Check warning
Code scanning / CodeQL
Information exposure through an exception
Comment on lines
+169
to
+172
| return { | ||
| "message": f"missing parameter: {str(err)}. please refer to API documentation for details", | ||
| "success": False, | ||
| }, 400 |
Check warning
Code scanning / CodeQL
Information exposure through an exception
Comment on lines
+174
to
+177
| return { | ||
| "message": f"Some errors occurred: {str(err)}", | ||
| "success": False, | ||
| }, 400 |
Check warning
Code scanning / CodeQL
Information exposure through an exception
wabinyai
approved these changes
Sep 7, 2023
|
Hi @sserurich , what is the actual status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT DOES THIS PR DO?
PR contains modifications in the locate microservice that enables recommendation for sensor placement utelising the smallest admin level for each country instead of restricting it to Parishes which are mainly in Uganda.
WHAT ISSUES ARE RELATED TO THIS PR?
Jira cards
GitHub issues
HOW DO I TEST OUT THIS PR?
WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:
ARE THERE ANY RELATED PRs?