more FPN parsing #29
more FPN parsing #29
Conversation
makrsmark
commented
Feb 16, 2024
makrsmark
commented
- adding procedures
- adding company route
- making routes in H1_M1BPOS and H1_POS consistent
- adding procedures - adding company route - making routes in H1_M1BPOS and H1_POS consistent
| expect(decodeResult.formatted.items[5].label).toBe('Message Checksum'); | ||
| expect(decodeResult.formatted.items[5].value).toBe('0xc8b5'); | ||
| expect(decodeResult.formatted.items[3].label).toBe('Company Route'); | ||
| expect(decodeResult.formatted.items[3].value).toBe('EWRDFW01(17L): >> SAAME > J6 > HVQ > Q68 > LITTR >> MEEOW >> FEWWW'); |
There was a problem hiding this comment.
it's a little funky, open to suggestions to changes in route_utils.ts
There was a problem hiding this comment.
I think this is fine for now. Once we see how the formatted versions look on Airframes and AcarsHub and/or get other feedback, we can always refine it. I'll keep you posted.
* added test case with comments in errors * fixed partial message notification
| }); | ||
|
|
||
| // https://app.airframes.io/messages/2372685289 | ||
| const text = 'FPN/TS140017,021724/RP:DA:EHAM:AA:KMSP..N55064W000477..N55163W001141..ERAKA..N60000W020000..N61000W030000:WS:N61000W030000,370..N61000W040000..N60000W050000..URTAK:WS:URTAK,380..LAKES:WS:LAKES,400..N57000W070000..N54300W080000..N49000W090000..DLH..COLDD:A:BAINY3:AP:ILS30L(30L)/PR4356,344,360,1060,,,13,,,30,,,P50,M40,36090,,3296,292/DTKMSP,30L,172,215117156D'; |
There was a problem hiding this comment.
this one is a beast - not sure how to approach it. adding it as a reference
There was a problem hiding this comment.
I like how you added a comment to the URL of the message for further info if we need it later.
Yeah, this is huge.
POS and #M1BPOS messages can have the same information embedded in it. Will update in a future PR
| }); | ||
|
|
||
| // https://app.airframes.io/messages/2372685289 | ||
| const text = 'FPN/TS140017,021724/RP:DA:EHAM:AA:KMSP..N55064W000477..N55163W001141..ERAKA..N60000W020000..N61000W030000:WS:N61000W030000,370..N61000W040000..N60000W050000..URTAK:WS:URTAK,380..LAKES:WS:LAKES,400..N57000W070000..N54300W080000..N49000W090000..DLH..COLDD:A:BAINY3:AP:ILS30L(30L)/PR4356,344,360,1060,,,13,,,30,,,P50,M40,36090,,3296,292/DTKMSP,30L,172,215117156D'; |
There was a problem hiding this comment.
I like how you added a comment to the URL of the message for further info if we need it later.
Yeah, this is huge.
| expect(decodeResult.formatted.items[2].label).toBe('Company Route'); | ||
| expect(decodeResult.formatted.items[2].value).toBe('PERMEL001'); | ||
| expect(decodeResult.formatted.items[3].label).toBe('Destination'); | ||
| expect(decodeResult.formatted.items[3].value).toBe('YMML..MEMUP,S33451E120525.Y53.WENDY'); //TODO - pull out route |
There was a problem hiding this comment.
Isn't this item the Destination? It would be an ICAO, right?
There was a problem hiding this comment.
yes, it should be just YMML - and then there's the route that's "how to get there"
>> MEMUP(33.451 S, 120.525 E) > Y53 > WENDY)
I'm not sure where to put the route right now because if you look above, there can be more route information - i probably should merge but punted on the hard stuff right now
|
Looking good. Seems like there's a couple of conflicts, but once those are fixed, merge away. Thanks @makrsmark ! |
|
@kevinelliott - merged master |
