adding H1-FPN decoding #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parses: * Flight Number * Route Status * Departure Airport * Departure Runway * Arrivial Airport * First Waypoint * Message Checksum Does not Parse: * Departure Procedure * Arrival Procedure * Current Route(?) Also does not put multiple 'First Waypoints' into context
makrsmark
commented
Feb 5, 2024
Comment on lines
+31
to
+34
| expect(decodeResult.formatted.items[3].label).toBe('Aircraft Route'); | ||
| expect(decodeResult.formatted.items[3].value).toBe('VECTOR >> DISCO >> RIVET'); | ||
| expect(decodeResult.formatted.items[4].label).toBe('Aircraft Route'); | ||
| expect(decodeResult.formatted.items[4].value).toBe('TACKE'); |
There was a problem hiding this comment.
this is weird, but right now First Waypoint isn't being taken into context
| for(let i=1; i< data.length; i+=2) { | ||
| const key = data[i]; | ||
| const value = data[i+1]; | ||
| // TODO: discuss how store commented out bits as both raw and formatted |
There was a problem hiding this comment.
i should probably discuss before putting out a PR, but sometimes i find it easier when there's code to point at
kevinelliott
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parses:
Does not Parse:
Also does not put multiple 'First Waypoints' into context