Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes draw methods for grayscale images #807

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

lgvaz
Copy link
Collaborator

@lgvaz lgvaz commented Apr 19, 2021

closes #806

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #807 (26121c3) into master (0d7f18d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   87.26%   87.34%   +0.07%     
==========================================
  Files         225      225              
  Lines        4697     4725      +28     
==========================================
+ Hits         4099     4127      +28     
  Misses        598      598              
Flag Coverage Δ
unittests 87.34% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icevision/visualize/draw_data.py 89.47% <100.00%> (ø)
icevision/core/tasks.py 100.00% <0.00%> (ø)
icevision/models/mmdet/fastai/callbacks.py 100.00% <0.00%> (ø)
icevision/models/torchvision/fastai/callbacks.py 100.00% <0.00%> (ø)
...sion/models/torchvision/lightning/model_adapter.py 100.00% <0.00%> (ø)
icevision/core/record_components.py 79.47% <0.00%> (+0.06%) ⬆️
icevision/core/mask.py 88.37% <0.00%> (+0.09%) ⬆️
icevision/models/mmdet/lightning/model_adapter.py 96.96% <0.00%> (+0.09%) ⬆️
...sion/tfms/albumentations/albumentations_adapter.py 95.58% <0.00%> (+0.11%) ⬆️
icevision/core/keypoints.py 93.33% <0.00%> (+0.22%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7f18d...26121c3. Read the comment docs.

@FraPochetti
Copy link
Contributor

I think this can be easily merged.

@lgvaz
Copy link
Collaborator Author

lgvaz commented Mar 9, 2022

@FraPochetti is this still a thing?

@FraPochetti
Copy link
Contributor

@FraPochetti is this still a thing?

We never got back to it.
Not sure it is relevant actually.

@rbavery
Copy link

rbavery commented Jun 24, 2022

this seems related: #1080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

draw_bbox fails for grayscale images
3 participants