Use eth_hw_addr_set instead of dev_addr_set #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of define a dev_addr_set alias, eth_hw_addr_set should be declared for kernels < 5.15
eth_hw_addr_set was introduced on v5.15-rc1
torvalds/linux@48eab83
For old kernels memcpy() is used, so we do the same is this patch.
It's aligned with the solution used by similar drivers on Linux kernel.
memcopy to ether_addr_copy to eth_hw_addr_set
See for example
torvalds/linux@b57ceb1
torvalds/linux@349f631
Kernels < v5.15 will works in the same way with or without this patch, but maybe solve some issues with newer kernels, where eth_hw_addr_set has been improved.
ping @fariouche to test #1088 @Anoncheg1 for #1075 and @Reflexe to test on ArchLinux #961
Fix #1088