Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[S3-data-lake] Remove/Rename all occurences of iceberg.v2 #51012

Merged
merged 9 commits into from
Jan 9, 2025
Merged

[S3-data-lake] Remove/Rename all occurences of iceberg.v2 #51012

merged 9 commits into from
Jan 9, 2025

Conversation

frifriSF59
Copy link
Contributor

What

Update all occurrences of iceberg.v2 in our code since it should now be called s3-data-lake

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11314

@frifriSF59 frifriSF59 requested a review from edgao January 9, 2025 17:37
@frifriSF59 frifriSF59 self-assigned this Jan 9, 2025
@frifriSF59 frifriSF59 requested a review from a team as a code owner January 9, 2025 17:37
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 7:34pm

@frifriSF59 frifriSF59 changed the title Remove/Rename all occurences of iceberg.v2 [S3-data-lake] Remove/Rename all occurences of iceberg.v2 Jan 9, 2025
@frifriSF59
Copy link
Contributor Author

frifriSF59 commented Jan 9, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (3d3011e)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 9, 2025
@frifriSF59 frifriSF59 enabled auto-merge (squash) January 9, 2025 18:29
edgao
edgao approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably also worth renaming e.g. IcebergDestination -> S3DataLakeDestination? otherwise lgtm

@frifriSF59 frifriSF59 merged commit 762e370 into master Jan 9, 2025
30 checks passed
@frifriSF59 frifriSF59 deleted the frifri/s3-data-lake-folder-cleanup branch January 9, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees

@frifriSF59 frifriSF59

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3-data-lake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frifriSF59 @edgao @octavia-squidington-iii