Destination S3V2: Restore Thread-Safety to Unique Key Counter #50989
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
benmoriceau
approved these changes
Jan 8, 2025
tryangul
approved these changes
Jan 8, 2025
johnny-schmidt
force-pushed
the
jschmidt/s3v2/restore-thread-safety-for-key-counts
branch
from
83a93e7 to
af7d487
Compare
octavia-squidington-iii
added
the
area/documentation
johnny-schmidt
force-pushed
the
jschmidt/s3v2/restore-thread-safety-for-key-counts
branch
from
bb92632 to
7fd6556
Compare
johnny-schmidt
force-pushed
the
jschmidt/s3v2/restore-thread-safety-for-key-counts
branch
2 times, most recently
from
dcfe63f to
814f7cb
Compare
johnny-schmidt
force-pushed
the
jschmidt/s3v2/restore-thread-safety-for-key-counts
branch
from
814f7cb to
a235199
Compare
johnny-schmidt
force-pushed
the
jschmidt/s3v2/restore-thread-safety-for-key-counts
branch
from
a235199 to
85a29df
Compare
johnny-schmidt
force-pushed
the
jschmidt/s3v2/restore-thread-safety-for-key-counts
branch
from
85a29df to
32fb615
Compare
johnny-schmidt
deleted the
jschmidt/s3v2/restore-thread-safety-for-key-counts
branch
johnny-schmidt
restored the
jschmidt/s3v2/restore-thread-safety-for-key-counts
branch
|
Actually looks like rc.5 got in ahead of you, so you'll need to bump this to rc.6. I'll take care of rolling forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The changes here removed the access lock around the unique key counter as well as the one around the object list.
This likely caused the unique keys not to be visible across threads, resulting in this failure https://cloud.airbyte.com/workspaces/53a30509-28a4-4158-9c84-200cbad69a25/connections/1e5881b2-1745-437d-8420-d9957a3e4467/timeline?openLogs=true&eventId=403efe8f-a47b-4fb0-81ef-5bdd234394c3. (That exception indicates that multiple process records workers tried to write to the same filename.)
The bug itself caused no harm due to the extra uniqueness check, but it's a simple fix.
(I also cleaned up the alarming log message in the Checker that made me think this was worse than it was. : )