Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: remove deprecated --no-update flag from poetry commands #50988

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Jan 8, 2025

What

The --no-update flag has been deprecated in poetry version 2.0.0, causing issues with poetry builds in our regression tests (and likely affecting other airbyte-ci commands). This PR removes the flag from our commands in airbyte-ci.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 9:08pm

@ChristoGrab ChristoGrab marked this pull request as ready for review January 8, 2025 20:46
@ChristoGrab ChristoGrab requested a review from a team as a code owner January 8, 2025 20:46
@ChristoGrab
Copy link
Contributor Author

ChristoGrab commented Jan 8, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (13097b9)

@ChristoGrab ChristoGrab requested a review from maxi297 January 8, 2025 21:02
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@ChristoGrab ChristoGrab merged commit b8f4274 into master Jan 8, 2025
30 checks passed
@ChristoGrab ChristoGrab deleted the christo/fix-poetry-ci-builds branch January 8, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants