Skip to content

Commit

Permalink
Revert "chore: Use CRT http engine. (#51021)"
Browse files Browse the repository at this point in the history
This reverts commit e7b8fc4.
  • Loading branch information
tryangul committed Jan 10, 2025
1 parent 2200bec commit 1a03005
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
3 changes: 1 addition & 2 deletions airbyte-cdk/bulk/toolkits/load-s3/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@ dependencies {
api project(':airbyte-cdk:bulk:toolkits:bulk-cdk-toolkit-load-object-storage')

testFixturesApi(testFixtures(project(":airbyte-cdk:bulk:toolkits:bulk-cdk-toolkit-load-object-storage")))
implementation("aws.sdk.kotlin:s3:1.3.98")
implementation("aws.smithy.kotlin:http-client-engine-crt:1.3.31")
implementation("aws.sdk.kotlin:s3:1.3.94")
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import aws.sdk.kotlin.services.s3.model.PutObjectRequest
import aws.smithy.kotlin.runtime.auth.awscredentials.CredentialsProvider
import aws.smithy.kotlin.runtime.content.ByteStream
import aws.smithy.kotlin.runtime.content.toInputStream
import aws.smithy.kotlin.runtime.http.engine.crt.CrtHttpEngine
import aws.smithy.kotlin.runtime.net.url.Url
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
import io.airbyte.cdk.load.command.aws.AWSAccessKeyConfigurationProvider
Expand Down Expand Up @@ -245,10 +244,6 @@ class S3ClientFactory(
Url.parse(it)
} else null
}

// Fix for connection reset issue:
// https://github.com/awslabs/aws-sdk-kotlin/issues/1214#issuecomment-2464831817
httpClient(CrtHttpEngine)
}

return S3Client(
Expand Down

0 comments on commit 1a03005

Please sign in to comment.