Add nodeSelector, tolerations, and affinity to minio create bucket pod #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@octavia-approvington Anyone from Airbyte team could be check this PR please ? Could be important to have this for multi-architecture kubernetes cluster. Thanks in advance |
|
Can this get a bump because this would be extremely useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The minio create bucket pod does not inherit the tolerations and affinities the main minio does. We need the ability to define where this pod runs. In our install this pod does not run and the helm chart leaves an error condition.
How
The create bucket pod uses the same settings as the other minio pods.
Recommended reading order
x.kty.ktCan this PR be safely reverted and rolled back?