Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loadBalancerIP to service spec in APIs charts #307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add loadBalancerIP to service spec in APIs charts #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/airbyte-api-server/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ metadata:
{{- include "airbyte.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.type }}
{{- if and .Values.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.service.loadBalancerIP }}
{{- end }}
ports:
- port: {{ .Values.service.port }}
targetPort: http
Expand Down
4 changes: 1 addition & 3 deletions charts/airbyte-api-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

global:
serviceAccountName: placeholderServiceAccount
deploymentMode: oss
Expand Down Expand Up @@ -136,6 +135,7 @@ resources:
## service.port The service port to expose the API server on
service:
type: ClusterIP
loadBalancerIP: ""
port: 8006
annotations: {}

Expand Down Expand Up @@ -255,13 +255,11 @@ secrets: {}
# CONFIGS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION: 0.35.15.001
env_vars: {}


## extraSelectorLabels [object] - use to specify own additional selector labels for deployment
extraSelectorLabels: {}
## extraLabels [object] - use to specify own additional labels for deployment
extraLabels: {}


## deploymentStrategyType [string] - deployment strategy type for airbyte-server deployment.
## Defaults to Recreate since the pod is using pvc
deploymentStrategyType: Recreate
Expand Down
3 changes: 3 additions & 0 deletions charts/airbyte-server/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ metadata:
{{- include "airbyte.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.type }}
{{- if and .Values.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.service.loadBalancerIP }}
{{- end }}
ports:
- port: {{ .Values.service.port }}
targetPort: http
Expand Down
4 changes: 1 addition & 3 deletions charts/airbyte-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

global:
serviceAccountName: placeholderServiceAccount
edition: community
Expand Down Expand Up @@ -98,6 +97,7 @@ resources:
## service.port The service port to expose the API server on
service:
type: ClusterIP
loadBalancerIP: ""
port: 8001
annotations: {}

Expand Down Expand Up @@ -193,13 +193,11 @@ secrets: {}
# CONFIGS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION: 0.35.15.001
env_vars: {}


## extraSelectorLabels [object] - use to specify own additional selector labels for deployment
extraSelectorLabels: {}
## extraLabels [object] - use to specify own additional labels for deployment
extraLabels: {}


## deploymentStrategyType [string] - deployment strategy type for airbyte-server deployment.
## Defaults to Recreate since the pod is using pvc
deploymentStrategyType: Recreate
Expand Down
Loading