fix: don't include all of lodash #1847
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
reviewed
Jun 6, 2024
There was a problem hiding this comment.
thanks for the improvement here @RobinClowers ! 馃檶 had a quick comment on the non-root lock files.
packages/visx-shape/yarn.lock
Outdated
| @@ -0,0 +1,293 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
we avoid committing lock files in specific packages, and just have them in the monorepo root. could you remove these and then re-run yarn in the root just to make sure the root lock file is good?
RobinClowers
force-pushed
the
fix-lodash-dependency
branch
from
8608590
to
95ac4ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃挜 Breaking Changes
馃殌 Enhancements
visx-responsive,visx-text, andvisx-xychart.馃摑 Documentation
馃悰 Bug Fix
馃彔 Internal