feat!: use ecmaVersion latest #2965
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code is often used when using @eslint/eslintrc with `eslint-config-airbnb-base`:
```js
// mimic CommonJS variables -- not needed if using CommonJS
const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: pluginJs.configs.recommended});
```
However, `import.meta` is not supported in ecmaVersion: '2018'. This change allows users to be able to use it that way.
|
related: eslint/create-config#51 |
ljharb
requested changes
Apr 10, 2024
| @@ -10,7 +10,7 @@ module.exports = { | |||
| './rules/strict', | |||
| ].map(require.resolve), | |||
| parserOptions: { | |||
| ecmaVersion: 2018, | |||
| ecmaVersion: 'latest', | |||
There was a problem hiding this comment.
this is a change we can't make unless babel-preset-airbnb is handling it by default. unfortunately i no longer maintain it, so I'm not familiar with what the latest version supports.
There was a problem hiding this comment.
seems it's no longer actively maintained - the last version was released ~4 years ago.
There was a problem hiding this comment.
accurate. but this is airbnb's eslint config, so my hands are kind of tied :-/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code is often used when using
@eslint/eslintrcwitheslint-config-airbnb-base:However,
import.metais not supported in ecmaVersion: '2018'. This change allows users to be able to use it that way.