added some changes in react readme file #2625
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
master
branch
from
d723c7e
to
7bdde30
Compare
ljharb
requested changes
Aug 12, 2022
| @@ -29,6 +29,9 @@ This style guide is mostly based on the standards that are currently prevalent i | |||
| - Always use JSX syntax. | |||
| - Do not use `React.createElement` unless you’re initializing the app from a file that is not JSX. | |||
| - [`react/forbid-prop-types`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-prop-types.md) will allow `arrays` and `objects` only if it is explicitly noted what `array` and `object` contains, using `arrayOf`, `objectOf`, or `shape`. | |||
| - Consider not using React memo,useMemo and useCallback hooks in the code unless there is no way to write the code. | |||
There was a problem hiding this comment.
why? These hooks are critically important and should often be used - see https://attardi.org/why-we-memo-all-the-things/
| @@ -29,6 +29,9 @@ This style guide is mostly based on the standards that are currently prevalent i | |||
| - Always use JSX syntax. | |||
| - Do not use `React.createElement` unless you’re initializing the app from a file that is not JSX. | |||
| - [`react/forbid-prop-types`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-prop-types.md) will allow `arrays` and `objects` only if it is explicitly noted what `array` and `object` contains, using `arrayOf`, `objectOf`, or `shape`. | |||
| - Consider not using React memo,useMemo and useCallback hooks in the code unless there is no way to write the code. | |||
| - React specific file names should start with Capital letter where as Javascript specific file name can start with small letter. | |||
There was a problem hiding this comment.
absolutely not; capitalization of values and filenames has nothing to do with React, and is a JavaScript-wide convention.
| @@ -29,6 +29,9 @@ This style guide is mostly based on the standards that are currently prevalent i | |||
| - Always use JSX syntax. | |||
| - Do not use `React.createElement` unless you’re initializing the app from a file that is not JSX. | |||
| - [`react/forbid-prop-types`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-prop-types.md) will allow `arrays` and `objects` only if it is explicitly noted what `array` and `object` contains, using `arrayOf`, `objectOf`, or `shape`. | |||
| - Consider not using React memo,useMemo and useCallback hooks in the code unless there is no way to write the code. | |||
| - React specific file names should start with Capital letter where as Javascript specific file name can start with small letter. | |||
| - Try to write folder specific components,so its easy to navigate. | |||
There was a problem hiding this comment.
Can you elaborate on this?
Comment on lines
+58
to
+72
| ```filenames in React | ||
| // bad | ||
| header.jsx | ||
|
|
||
| //good | ||
| Header.jsx | ||
|
|
||
|
|
||
| ```filenames in Javascript | ||
| //bad | ||
| Header.js | ||
|
|
||
| //good | ||
| header.js | ||
|
|
There was a problem hiding this comment.
please remove this; this is not a good thing to recommend nor will the airbnb guide likely ever recommend it.
sandeepvinnu
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.