Allow using key columns as input to derivations #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaohui-sun
changed the title
hzding621
reviewed
Feb 12, 2025
xiaohui-sun
force-pushed
the
derivation_joinkey
branch
from
72a33db to
cd9d1a5
Compare
yuli-han
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Could you try to test the fetcher behavior on a gateway? Usually the step is:
- update an existing testing join derivation with derivation on key in the zipline_test folder
- run metadata-upload to upload the new join schema to k-v store metadata store
- upload the local jar to a remote gateway with the new change.
- run fetcher cli to validate the change
This is the procedure I am running when changing the fetcher, cc @hzding621 @pengyu-hou could you pls share if you know any simpler way to test or if there are existing doc for the testing procedure? Also pls lemme know if you need the command to run the steps.
xiaohui-sun
force-pushed
the
derivation_joinkey
branch
from
2054fc3 to
5175c63
Compare
hzding621
approved these changes
Feb 12, 2025
|
+1 to fetchercli testing as to what @yuli-han said |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for using key columns as input to derivations.
Why / Goal
Test Plan
Checklist
Reviewers
@hzding621
@yuli-han