Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-202): add Type References section #1345

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

noahdietz
Copy link
Collaborator

Stage AIP update for new google.api.FieldInfo.referenced_types field in AIP-202 and guidance for using it on Any fields in AIP-146.

@noahdietz noahdietz requested a review from a team as a code owner April 18, 2024 18:46
@noahdietz noahdietz requested review from itsStrobe, andrei-scripniciuc and jskeet and removed request for itsStrobe April 18, 2024 18:46
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally happy - some tweaks suggested.

aip/general/0202.md Show resolved Hide resolved
aip/general/0202.md Outdated Show resolved Hide resolved
aip/general/0202.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even better to me now :)

@pinalbaldha pinalbaldha self-requested a review May 19, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants