Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AIP-203): Clarify that IDENTIFIER fields must not use other behaviors #1310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(AIP-203): Clarify that IDENTIFIER fields must not use other behaviors #1310

wants to merge 2 commits into from

Conversation

andrei-scripniciuc
Copy link
Contributor

Fields marked as IDENTIFIER must not use other annotations, as they are either already implied or are mutually exclusive:

  • IMMUTABLE: Implicit
  • INPUT_ONLY: False, IDENTIFIER must be part of resource responses
  • OPTIONAL: False, field is required on Create
  • OUTPUT_ONLY: False, field is user-specified on Create
  • REQUIRED: Implicit
  • UNORDERED_LIST: Mutually exclusive, since IDENTIFIER fields must be of type string

@andrei-scripniciuc andrei-scripniciuc requested a review from a team as a code owner February 16, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

@itsStrobe itsStrobe Awaiting requested review from itsStrobe itsStrobe is a code owner automatically assigned from aip-dev/google

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607 bgrant0607 is a code owner automatically assigned from aip-dev/google

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrei-scripniciuc @noahdietz