Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling empty segments in urls according to RFC3986 #1026

Merged
merged 38 commits into from
Jul 3, 2024

docs - == != =

1c3b9ce
Select commit
Loading
Failed to load commit list.
Merged

Improve handling empty segments in urls according to RFC3986 #1026

docs - == != =
1c3b9ce
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 1, 2024 in 0s

62.04% (target 100.00%)

View this Pull Request on Codecov

62.04% (target 100.00%)

Details

Codecov Report

Attention: Patch coverage is 74.46809% with 12 lines in your changes missing coverage. Please review.

Project coverage is 62.04%. Comparing base (0baa61a) to head (1c3b9ce).

Files Patch % Lines
tests/test_url.py 68.75% 10 Missing ⚠️
yarl/_url.py 86.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   61.96%   62.04%   +0.07%     
==========================================
  Files          38       38              
  Lines        6510     6550      +40     
  Branches      353      352       -1     
==========================================
+ Hits         4034     4064      +30     
- Misses       2448     2458      +10     
  Partials       28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov