Update workflows to run on GitHub #328

wbarnha · 2023-04-16T18:30:08Z

What do these changes do?

Run CI/CD jobs on GitHub instead of legacy Travis.

Are there changes in behavior for the user?

We can start releasing updates again, soon 😄

Related issue number

Branching off #327

Checklist

I think the code is well written
Unit tests for the changes exist
Documentation reflects the changes
Add a new news fragment into the CHANGES folder
- name it <issue_id>.<type> (e.g. 588.bugfix)
- if you don't have an issue_id change it to the pr id after creating the PR
- ensure type is one of the following:
  - .feature: Signifying a new feature.
  - .bugfix: Signifying a bug fix.
  - .doc: Signifying a documentation improvement.
  - .removal: Signifying a deprecation or removal of public API.
  - .misc: A ticket has been closed, but it is not of interest to users.
- Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

This reverts commit 10e1052.

- Name all jobs and steps explicitly. - Ensure the names to come first in the YAML for readability. - Let the lint/typecheck jobs to use `PYTHON_LATEST` env-var.

* There seems no way to set "biweekly"...

.github/workflows/default.yml

webknjaz · 2023-04-25T00:52:39Z

.github/workflows/default.yml

+  PYTHON_LATEST: "3.11"
+
+  # For re-actors/checkout-python-sdist
+  sdist-artifact: python-package-distributions

 jobs:
  lint-flake8:


How about separating the linting jobs into a dedicated reusable workflow?

webknjaz · 2023-04-25T00:53:13Z

.github/workflows/default.yml

      with:
-        fetch-depth: 2
+        fetch-depth: 0


Is this bit really needed for linting?

webknjaz · 2023-04-25T00:58:34Z

.github/workflows/default.yml

+      - run: python -Im pip install build
+        name: Install core libraries for build and install
+      - name: Build artifacts
+        run: python -Im build


Since the linting jobs currently don't depend on this one, maybe it's a good idea to run twine check --strict after this step. Alternatively, I'd put linting in a dedicated job.

achimnol · 2023-04-25T08:41:19Z

@webknjaz Q. Should I add some if: conditions to the second job (Publish to GitHub Pages) in the docs.yml workflow, as it's reporting deployment failure due to missing permission of this branch? It seems that all future PR branches will have the same issue.

achimnol · 2023-04-25T18:09:12Z

@webknjaz Q. Should I add some if: conditions to the second job (Publish to GitHub Pages) in the docs.yml workflow, as it's reporting deployment failure due to missing permission of this branch? It seems that all future PR branches will have the same issue.

We decided to migrate to .readthedocs.yml and remove docs.yml.

achimnol · 2023-04-25T18:15:23Z

For follow-ups, see #352.

wbarnha added 30 commits February 22, 2023 18:00

commit inital changes

6e07de6

add setuptools_scm

10e1052

Revert "add setuptools_scm"

b50a628

This reverts commit 10e1052.

add more updates

bd9aff7

remove all references to loop=loop

1b132c8

revert change

e532509

revert changes

3b88964

revert changes

d896c0a

fix all_tasks call

82cb4a8

add dist.yaml

a5790dd

add gh-pages.yml

a5f4736

always deploy docs for now

972952f

bump notes for 0.4.6

51d92b0

freeze versions in requirements-dev.txt

0891791

Merge branch 'revive-cicd'

effe33b

eol py3.7

371d36b

Merge branch 'revive-cicd'

dc85438

experiment with caching

93eea6a

change rules

509bae4

experiment with new flow

5050099

rename main to master

9ae510b

replace needs:check with needs:tests

bc31f2c

rename environ_config to aiiomoitor

5b1784d

use setuptools_scm and importlib for automatic versioning

044876b

disable py3.7

cda3d3d

disable nox usage

96e16ef

fix setup.py flaking

7b8285b

fix doc build

5c434ad

disable 3.12 tests

6745629

rename refernces from aiomysql to aiomontior

94b6e68

achimnol added 10 commits April 24, 2023 14:25

ci: Merge the contents of ci-cd.yml and default.yml

86d292d

- Name all jobs and steps explicitly. - Ensure the names to come first in the YAML for readability. - Let the lint/typecheck jobs to use `PYTHON_LATEST` env-var.

ci: Fix the needs list

c235552

fix: Rename gh-page.yml to docs.yml and fix typo

4ac71bc

fix: Remove duplicate step names

0f3952a

ci: Use the ghactions doc way of marking experimental tests

369145e

ci: Fix renaming job steps

0b158e7

ci: Relax the dependabot check interval to one month

d2ecaa1

* There seems no way to set "biweekly"...

ci: Let docs workflow install only required stuffs

7d00298

ci: Fix the docs workflow

13f58de

Instruct git to render .git_archival.txt

a2fcf69

webknjaz reviewed Apr 25, 2023

View reviewed changes

achimnol added 2 commits April 25, 2023 02:16

ci: Run build-sdist first

f9bff01

ci: Rename default.yml to ci-cd.yml

e1f8e02

achimnol had a problem deploying to github-pages April 25, 2023 08:18 — with GitHub Actions Failure

ci: Let it run sdist-build always and remove "-I" on pip invocation

93c19f0

achimnol had a problem deploying to github-pages April 25, 2023 08:20 — with GitHub Actions Failure

fix: Make type-anno compatible with Python 3.8

de09c69

achimnol had a problem deploying to github-pages April 25, 2023 08:21 — with GitHub Actions Failure

fix: Make type anno compatible with Python 3.8

85cf3ed

achimnol had a problem deploying to github-pages April 25, 2023 08:25 — with GitHub Actions Failure

achimnol mentioned this pull request Apr 25, 2023

Make type-anno compatible with Python 3.8 #338

Merged

4 tasks

Merge branch 'master' into update-workflows

a481650

achimnol had a problem deploying to github-pages April 25, 2023 18:24 — with GitHub Actions Failure

achimnol merged commit 64497f8 into aio-libs:master Apr 25, 2023

This was referenced Apr 25, 2023

Migrate the docs to readthedocs #351

Merged

Split out setup.cfg from pyproject.toml #358

Merged

achimnol added the maintenance label Apr 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update workflows to run on GitHub #328

Update workflows to run on GitHub #328

wbarnha commented Apr 16, 2023 •

edited

Loading

webknjaz Apr 25, 2023

webknjaz Apr 25, 2023

webknjaz Apr 25, 2023

achimnol commented Apr 25, 2023

achimnol commented Apr 25, 2023

achimnol commented Apr 25, 2023 •

edited

Loading

Update workflows to run on GitHub #328

Update workflows to run on GitHub #328

Conversation

wbarnha commented Apr 16, 2023 • edited Loading

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

webknjaz Apr 25, 2023

Choose a reason for hiding this comment

webknjaz Apr 25, 2023

Choose a reason for hiding this comment

webknjaz Apr 25, 2023

Choose a reason for hiding this comment

achimnol commented Apr 25, 2023

achimnol commented Apr 25, 2023

achimnol commented Apr 25, 2023 • edited Loading

wbarnha commented Apr 16, 2023 •

edited

Loading

achimnol commented Apr 25, 2023 •

edited

Loading