🧪 Run tests from sdist like downstreams - #13388
Conversation
webknjaz
added
infra
meta
github_actions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13388 +/- ##
==========================================
- Coverage 98.99% 98.41% -0.59%
==========================================
Files 132 133 +1
Lines 49454 49746 +292
Branches 2572 2629 +57
==========================================
- Hits 48959 48958 -1
- Misses 371 663 +292
- Partials 124 125 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
76ee2ad to
69d5ed8
Compare
Merging this PR will improve performance by 8.66%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_simple_web_file_response[ssl-large] |
307.7 ms | 281.5 ms | +9.3% |
| ⚡ | test_resolve_gitapi |
644.3 ms | 594.2 ms | +8.42% |
| ⚡ | test_resolve_gitapi_subapps |
654.3 ms | 604.4 ms | +8.26% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing webknjaz:testing/wheel-ci-cd-from-sdist (c41a21f) with master (d041d4d)2
Footnotes
-
83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
master(77c5108) during the generation of this report, so d041d4d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
d059b68 to
b99dc7b
Compare
This allows us make sure everything they need is shipped through PyPI. And brings us closer to how `pip install` would build wheels in the wild. We now also run tests in CI from sdist. And this should help us out getting CI/CD to: * aio-libs#7632 * aio-libs#13363 * aio-libs#13353
b99dc7b to
21560bc
Compare
21560bc to
c41a21f
Compare
1 participant
What do these changes do?
This allows us make sure everything they need is shipped through PyPI. And brings us closer to how
pip installwould build wheels in the wild. We now also run tests in CI from sdist.Are there changes in behavior for the user?
Nope.
Is it a substantial burden for the maintainers to support this?
It's actually bringing the infra closer to the rest of the repos. So it's a win.
Related issue number
And this should help us out getting CI/CD to:
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.