Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: general refactoring, closing todos #1328

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

Lopa10ko
Copy link
Collaborator

@Lopa10ko Lopa10ko commented Aug 29, 2024

This is a 🔨 code refactoring.

Summary

  • add prediction saving mechanism for FEDOT-native OutputData (804ef43)
  • add binary clf to the metrics test (8795a55)
  • add ar to a minimal set for fast train forecasting (f15a7a1)
  • add nodes: List[PipelineNode] property to fix unresolved references (5c27ac8)

@Lopa10ko Lopa10ko self-assigned this Aug 29, 2024
@pep8speaks
Copy link

pep8speaks commented Aug 29, 2024

Hello @Lopa10ko! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 3:1: F401 'pathlib.Path' imported but unused

Line 2:1: F401 'sys' imported but unused

Comment last updated at 2024-09-12 19:07:00 UTC

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Code in this pull request still contains PEP8 errors, please write the /fix-pep8 command in the comments below to create commit with automatic fixes.

Comment last updated at

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (92218df) to head (5c27ac8).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
fedot/core/data/data.py 20.00% 8 Missing ⚠️
fedot/api/main.py 50.00% 5 Missing ⚠️
fedot/api/fedot_cli.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1328      +/-   ##
==========================================
- Coverage   80.14%   80.10%   -0.04%     
==========================================
  Files         146      146              
  Lines       10285    10296      +11     
==========================================
+ Hits         8243     8248       +5     
- Misses       2042     2048       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants