Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go for forecast method instead of predict in ets #1299

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

Lopa10ko
Copy link
Collaborator

@Lopa10ko Lopa10ko commented Jun 6, 2024

This is a 🐛 bug fix.
Related to api_ts_forecasting_example integration test failure.

  • Change predict logic by calling forecasting method instead of a predict one in ExpSmoothingImplementation (27315b2)
  • Make sure that this resolves the issue with that kind of pipelines by running saved troubled pipelines locally
  • Remove obsolete custom message logging level (da4fc93)

related to #1297, but not closing it since there are various types of troubled pipelines
closes #1300

@Lopa10ko Lopa10ko self-assigned this Jun 6, 2024
Copy link

docu-mentor bot commented Jun 6, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

@Lopa10ko
Copy link
Collaborator Author

Lopa10ko commented Jun 6, 2024

ap_ts_forecasting_example_predict_vs_forecast

Copy link
Contributor

github-actions bot commented Jun 6, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

Copy link
Collaborator

@nicl-nno nicl-nno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На проблему с ets хорошо бы тест добавить. Хотя бы для какого-то конкретного пайлпайна.

@Lopa10ko
Copy link
Collaborator Author

На проблему с ets хорошо бы тест добавить. Хотя бы для какого-то конкретного пайлпайна.

e43412e

@Lopa10ko Lopa10ko merged commit ec12d26 into master Jun 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NaN-containing predict on smoothing+gaussian_filter+ets pipeline
2 participants