Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal places control implemented #1161

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Decimal places control implemented #1161

merged 2 commits into from
Sep 4, 2023

Conversation

nicl-nno
Copy link
Collaborator

@nicl-nno nicl-nno commented Sep 1, 2023

Fix for get_metrics method

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1161 (37a175c) into master (cebd493) will increase coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
+ Coverage   78.30%   78.34%   +0.04%     
==========================================
  Files         130      130              
  Lines        9355     9354       -1     
==========================================
+ Hits         7325     7328       +3     
+ Misses       2030     2026       -4     
Files Changed Coverage Δ
fedot/api/main.py 56.03% <100.00%> (ø)

... and 5 files with indirect coverage changes

@@ -19,7 +18,7 @@ def run_classification_example(timeout: float = None, visualization=False, with_
auto_model.fit(features=train_data_path, target='target')
prediction = auto_model.predict_proba(features=test_data_path)

print(auto_model.get_metrics())
print(auto_model.get_metrics(decimal_places_num=4)) # we can control the rounding of metrics
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мб мне так кажется, но название громоздкое и неочевидное. Не знаю какое название используют на практике, но предложу, например rounding_order, чтобы была связь с округлением

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пусть будет, переименовал.

@nicl-nno nicl-nno merged commit 1a96f38 into master Sep 4, 2023
6 checks passed
@nicl-nno nicl-nno deleted the decimal-places-fix branch September 4, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants