Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kotlin coroutines #277

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

kacgal
Copy link

@kacgal kacgal commented Jul 8, 2020

Handles exceptions thrown by Kotlin suspend functions.

@aikar
Copy link
Owner

aikar commented Jul 8, 2020

I'm not interested in adding kotlin to the build. There has to be a less invasive way to pull this off....

Id suggest trying to achieve this by registering your own context, and maybe setting exception handler.

@kacgal
Copy link
Author

kacgal commented Jul 8, 2020

Do you mean that you don't want kotlin in every final jar of acf, or don't want kotlin at build time at all?
Because this method doesn't include kotlin in the jar, it's completely optional. Just required at build time

Edit: Sorry! I was wrong. <optional> didn't do what I expected!
But setting kotlin to scope = provided should do the trick

@bristermitten
Copy link

Surely this will cause a failure if Kotlin isn't on the classpath - i.e. if the plugin isn't using it?

@kacgal
Copy link
Author

kacgal commented Oct 15, 2020

No, there is no failure. The JVM does throw exceptions that the classes can't be found, but those are caught and silently ignored - meaning no Kotlin is required at runtime

@Nopock
Copy link

Nopock commented Feb 10, 2023

Lil late but any updates or future thoughts on this?

Nopock added a commit to Nopock/acf that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants