Typing fixes #196
Open
Typing fixes #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In aiida-core, we're passing a set() as haskeys argument, but set is not a Sequence so mypy in aiida-core complains. typing.Iterable correctly captures the type what we accept, since we anyway convert it to `set` internally.
danielhollas
commented
Nov 4, 2025
|
|
||
| if TYPE_CHECKING: | ||
| from container import ObjectType | ||
| from .container import ObjectType |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 10 10
Lines 2143 2143
=======================================
Hits 2136 2136
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@edan-bainglass since you've reviewed the corresponding |
Author
|
Cheers @edan-bainglass 🫶 I can't merge PRs on this repo so leaving that to @GeigerJ2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains to typing fixes that were uncovered by adding typing in aiida-core in aiidateam/aiida-core#7049
In aiida-core, we're passing a
set()as hashkeys argument, but set is not a Sequence so mypy in aiida-core complains.typing.Iterablecorrectly captures the type what we accept here since we anyway convert it tosetinternally.Remove usage of
mypy_extensions.Argwhich is deprecated and doesn't actually work as intended over at aiida-core repo.