Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with aiida 2.6.2 #616

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Jul 2, 2024

Just released a new image with aiida-2.6.2 so we should switch our tests (both notebook tests and unit tests) here to this version.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (ce9cfe9) to head (fe4d762).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #616   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files          17       17           
  Lines        3539     3539           
=======================================
  Hits         2955     2955           
  Misses        584      584           
Flag Coverage Δ
python-3.11 83.49% <ø> (ø)
python-3.9 83.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas danielhollas changed the title Test with aiida 2.6.1 and Python 3.11 Test with aiida 2.6.1 Jul 2, 2024
@danielhollas danielhollas added the blocked This issue/PR is blocked by another issue/PR. label Jul 8, 2024
@danielhollas
Copy link
Contributor Author

Blocked on aiidalab/aiidalab-docker-stack#474

@danielhollas danielhollas marked this pull request as ready for review September 6, 2024 12:47
@danielhollas danielhollas removed the blocked This issue/PR is blocked by another issue/PR. label Sep 6, 2024
@danielhollas danielhollas changed the title Test with aiida 2.6.1 Test with aiida 2.6.2 Sep 6, 2024
@danielhollas danielhollas enabled auto-merge (squash) September 7, 2024 00:06
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @danielhollas
Tests are all passed so I think it is good to ship.

@danielhollas danielhollas merged commit 1d119fb into aiidalab:master Sep 18, 2024
11 checks passed
@danielhollas danielhollas deleted the test-aiida-2.6.1 branch September 18, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants