-
Notifications
You must be signed in to change notification settings - Fork 17
E2E Test Foundations #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Test Foundations #207
Conversation
be46b8b to
d619435
Compare
2270528 to
1ec6616
Compare
ea2a448 to
224c0cc
Compare
|
Thanks @shayasoolin, I've integrated your feedback. Please take another look. |
|
@gflarity can you please rebase your PR so that i can look at the code from within the IDE, without a lot of errors? I have only partially looked at the code and i will anyways push the initial set of comments. There is a lot of code to still look at which i will do once you have rebased the PR. |
224c0cc to
dac70ab
Compare
np, done |
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
dac70ab to
5e3f015
Compare
Signed-off-by: Geoff Flarity <[email protected]>
fa9783b to
024712a
Compare
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
9121511 to
b3b8842
Compare
Signed-off-by: Geoff Flarity <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @gflarity! The framework looks great -
I've added minor nits.
4fed6fa to
c9b280a
Compare
Signed-off-by: Geoff Flarity <[email protected]>
8a16995 to
d51ea1d
Compare
Thanks for the feedback @renormalize. I've implemented all the changes. I'll chat with @sanjaychatterjee and get this merged. |
As discussed in the meeting, we can just merge this can address any outstanding feedback in follow up PRs since this doesn't affect the operator itself at all.
What type of PR is this?
/kind test
What this PR does / why we need it:
This PR introduces E2E tests for grove. It uses k3d which in turn leverages k3s, I lightweight yet compliant Kubernetes distribution.These were selected for their performance and ability to limit the amount of memory per worker/agent node.
The goal was use pure Go libraries as much as possible E2E.
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.:
Here's sample of test results:
