Skip to content

Conversation

@gflarity
Copy link
Contributor

@gflarity gflarity commented Oct 2, 2025

What type of PR is this?

/kind test

What this PR does / why we need it:

This PR introduces E2E tests for grove. It uses k3d which in turn leverages k3s, I lightweight yet compliant Kubernetes distribution.These were selected for their performance and ability to limit the amount of memory per worker/agent node.

The goal was use pure Go libraries as much as possible E2E.

Special notes for your reviewer:

  • I was able to get all Gang-Scheduling tests from Grove Multi-Node Test Plan working, but I removed most of them to keep this PR managable.
  • E2E tests are currently disabled by default. I'd like to discuss when we want these to run before I enable them as the full tests take about 15m.
  • Currently all E2E tests run KAI and assume it's running, the future when there are more scheduling options we can change this.

Does this PR introduce a API change?

NONE

Additional documentation e.g., enhancement proposals, usage docs, etc.:


You'll need to run prepare charts at least once:
`./operator/hack/prepare-chart.sh`

For best results, run go test with -v and -p 1: 
`go test -v -tags=e2e -p 1 ./e2e_testing/...`

Here's sample of test results:
Screenshot 2025-10-02 at 10 34 50 AM

@gflarity gflarity force-pushed the gflarity/e2e_tests_foundation branch from be46b8b to d619435 Compare October 3, 2025 16:35
@gflarity gflarity force-pushed the gflarity/e2e_tests_foundation branch 2 times, most recently from 2270528 to 1ec6616 Compare October 18, 2025 21:44
@gflarity gflarity force-pushed the gflarity/e2e_tests_foundation branch 2 times, most recently from ea2a448 to 224c0cc Compare October 21, 2025 19:56
@gflarity
Copy link
Contributor Author

Thanks @shayasoolin, I've integrated your feedback. Please take another look.

@gflarity gflarity requested a review from shayasoolin October 21, 2025 19:57
@unmarshall
Copy link
Collaborator

unmarshall commented Oct 26, 2025

@gflarity can you please rebase your PR so that i can look at the code from within the IDE, without a lot of errors?
Rebasing will resolve all the import package errors that are there in your PR (without rebase) due to migration to ai-dynamo

I have only partially looked at the code and i will anyways push the initial set of comments. There is a lot of code to still look at which i will do once you have rebased the PR.

@gflarity gflarity force-pushed the gflarity/e2e_tests_foundation branch from 224c0cc to dac70ab Compare October 27, 2025 15:14
@gflarity
Copy link
Contributor Author

@gflarity can you please rebase your PR so that i can look at the code from within the IDE, without a lot of errors? Rebasing will resolve all the import package errors that are there in your PR (without rebase) due to migration to ai-dynamo

I have only partially looked at the code and i will anyways push the initial set of comments. There is a lot of code to still look at which i will do once you have rebased the PR.

np, done

Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
Signed-off-by: Geoff Flarity <[email protected]>
@gflarity gflarity force-pushed the gflarity/e2e_tests_foundation branch from dac70ab to 5e3f015 Compare October 27, 2025 16:28
Signed-off-by: Geoff Flarity <[email protected]>
@gflarity gflarity force-pushed the gflarity/e2e_tests_foundation branch from fa9783b to 024712a Compare October 27, 2025 16:37
@gflarity gflarity force-pushed the gflarity/e2e_tests_foundation branch from 9121511 to b3b8842 Compare October 27, 2025 18:42
shayasoolin
shayasoolin previously approved these changes Oct 30, 2025
Copy link
Collaborator

@renormalize renormalize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @gflarity! The framework looks great -
I've added minor nits.

Signed-off-by: Geoff Flarity <[email protected]>
@gflarity gflarity force-pushed the gflarity/e2e_tests_foundation branch from 8a16995 to d51ea1d Compare October 31, 2025 17:30
@gflarity
Copy link
Contributor Author

gflarity commented Oct 31, 2025

Thanks for the PR @gflarity! The framework looks great - I've added minor nits.

Thanks for the feedback @renormalize. I've implemented all the changes. I'll chat with @sanjaychatterjee and get this merged.

@gflarity gflarity dismissed unmarshall’s stale review October 31, 2025 20:30

As discussed in the meeting, we can just merge this can address any outstanding feedback in follow up PRs since this doesn't affect the operator itself at all.

@gflarity gflarity merged commit 69b626c into ai-dynamo:main Oct 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants