Integration test infra #160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
… support Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
…ng readability Signed-off-by: Ron Kahn <[email protected]>
…iles Signed-off-by: Ron Kahn <[email protected]>
…ailable fields Signed-off-by: Ron Kahn <[email protected]>
…etter clique management Signed-off-by: Ron Kahn <[email protected]>
…and performance Signed-off-by: Ron Kahn <[email protected]>
Ronkahn21
requested review from
sanjaychatterjee and
unmarshall
as code owners
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
… support Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
…ng readability Signed-off-by: Ron Kahn <[email protected]>
…iles Signed-off-by: Ron Kahn <[email protected]>
…ailable fields Signed-off-by: Ron Kahn <[email protected]>
…etter clique management Signed-off-by: Ron Kahn <[email protected]>
…egration-test-infra # Conflicts: # operator/go.mod # operator/go.sum
Signed-off-by: Ron Kahn <[email protected]>
…c versions Signed-off-by: Ron Kahn <[email protected]>
Signed-off-by: Ron Kahn <[email protected]>
…s.go Signed-off-by: Ron Kahn <[email protected]>
…ponents.go Signed-off-by: Ron Kahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces integration test infrastructure and new resource support for the Grove operator, along with dependency upgrades and minor fixes. The main changes are the addition of a flexible test environment builder, new integration tests for PodGangSet controllers, support for PodCliqueScalingGroup CRDs, and updates to Kubernetes dependencies.
Integration test infrastructure:
EnvBuilderinoperator/test/integration/framework/builder.goto simplify the setup of envtest environments, including CRDs, controllers, webhooks, namespaces, and objects.framework/crds.go) and constants (framework/constants.go) to support integration tests. [1] [2]PodGangSet controller integration tests:
operator/test/integration/controllers/podgangset/reconciler_test.goverifying that PodGangSet creates child PodCliques and PodCliqueScalingGroups with correct ownership and properties.Minor test fix:
operator/internal/component/podgangset/podclique/podclique_test.goto match the new PodClique parameter signature.