Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option -j-gen-modules to generate JSON generic submodules → #416 #420

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smondet
Copy link

@smondet smondet commented Jan 3, 2025

PR checklist

  • New code has tests to catch future regressions
  • Documentation is up-to-date
  • CHANGES.md is up-to-date

Cf. interesting bit in the tests:

let test_generic () =
let module Stringables = struct
module type Mono = sig
type t
val of_string: string -> t
val to_string: ?len: int -> t -> string
end
end in
let test_involution (module M : Stringables.Mono) name input =
let x = M.of_string input in
let s = M.to_string x in
Alcotest.(check string) (sprintf "involution-%s" name) input s;
in

Arg.Unit (fun () ->
add_generic_modules := true),
"
Add genericity-friendly modules to -j output.";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify what we should expect here and/or add it to the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants