Merge pull request pybamm-team#3586 from chmabaur/issue-3543-thermal

Fix Issue 3543 - Thermal model not working for a composite electrode particle model with two (or more) phases
agriyakhetarpal · Dec 5, 2023 · b5fe6af · b5fe6af
2 parents ebacf49 + 030c99b
commit b5fe6af
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 24 deletions.
diff --git a/pybamm/models/submodels/interface/open_circuit_potential/base_ocp.py b/pybamm/models/submodels/interface/open_circuit_potential/base_ocp.py
@@ -90,8 +90,8 @@ def _get_standard_ocp_variables(self, ocp_surf, ocp_bulk, dUdT):
         if self.reaction in ["lithium-ion main", "lead-acid main"]:
             variables.update(
                 {
-                    f"{Domain} electrode entropic change [V.K-1]": dUdT,
-                    f"X-averaged {domain} electrode entropic change [V.K-1]": dUdT_av,
+                    f"{Domain} electrode {reaction_name}entropic change [V.K-1]": dUdT,
+                    f"X-averaged {domain} electrode {reaction_name}entropic change [V.K-1]": dUdT_av,
                 }
             )
 

diff --git a/pybamm/models/submodels/thermal/base_thermal.py b/pybamm/models/submodels/thermal/base_thermal.py
@@ -117,38 +117,59 @@ def _get_standard_coupled_variables(self, variables):
         # Total Ohmic heating
         Q_ohm = Q_ohm_s + Q_ohm_e
 
-        # Irreversible electrochemical heating
-        a_j_p = variables[
-            "Positive electrode volumetric interfacial current density [A.m-3]"
-        ]
-        eta_r_p = variables["Positive electrode reaction overpotential [V]"]
+        num_phases = int(getattr(self.options, 'positive')["particle phases"])
+        phase_names = [""]
+        if num_phases > 1:
+            phase_names = ["primary ", "secondary "]
+
+        Q_rxn_p, Q_rev_p = 0, 0
+        T_p = variables["Positive electrode temperature [K]"]
+        for phase in phase_names:
+            a_j_p = variables[
+                f"Positive electrode {phase}volumetric interfacial current density [A.m-3]"
+            ]
+            eta_r_p = variables[f"Positive electrode {phase}reaction overpotential [V]"]
+            # Irreversible electrochemical heating
+            Q_rxn_p += a_j_p * eta_r_p
+            # Reversible electrochemical heating
+            dUdT_p = variables[f"Positive electrode {phase}entropic change [V.K-1]"]
+            Q_rev_p += a_j_p * T_p * dUdT_p
+
+
+        num_phases = int(getattr(self.options, 'negative')["particle phases"])
+        phase_names = [""]
+        if num_phases > 1:
+            phase_names = ["primary", "secondary"]
+
         if self.options.electrode_types["negative"] == "planar":
             Q_rxn_n = pybamm.FullBroadcast(
                 0, ["negative electrode"], "current collector"
             )
+            Q_rev_n = pybamm.FullBroadcast(
+                0, ["negative electrode"], "current collector"
+            )
         else:
-            a_j_n = variables[
-                "Negative electrode volumetric interfacial current density [A.m-3]"
-            ]
-            eta_r_n = variables["Negative electrode reaction overpotential [V]"]
-            Q_rxn_n = a_j_n * eta_r_n
-        Q_rxn_p = a_j_p * eta_r_p
+            T_n = variables["Negative electrode temperature [K]"]
+            Q_rxn_n = 0
+            Q_rev_n = 0
+            for phase in phase_names:
+                a_j_n = variables[
+                    f"Negative electrode {phase}volumetric interfacial current density [A.m-3]"
+                ]
+                eta_r_n = variables[f"Negative electrode {phase}reaction overpotential [V]"]
+                # Irreversible electrochemical heating
+                Q_rxn_n += a_j_n * eta_r_n
+
+                # Reversible electrochemical heating
+                dUdT_n = variables[f"Negative electrode {phase}entropic change [V.K-1]"]
+                Q_rev_n += a_j_n * T_n * dUdT_n
+
+        # Irreversible electrochemical heating
         Q_rxn = pybamm.concatenation(
             Q_rxn_n, pybamm.FullBroadcast(0, "separator", "current collector"), Q_rxn_p
         )
 
         # Reversible electrochemical heating
-        T_p = variables["Positive electrode temperature [K]"]
-        dUdT_p = variables["Positive electrode entropic change [V.K-1]"]
-        if self.options.electrode_types["negative"] == "planar":
-            Q_rev_n = pybamm.FullBroadcast(
-                0, ["negative electrode"], "current collector"
-            )
-        else:
-            T_n = variables["Negative electrode temperature [K]"]
-            dUdT_n = variables["Negative electrode entropic change [V.K-1]"]
-            Q_rev_n = a_j_n * T_n * dUdT_n
-        Q_rev_p = a_j_p * T_p * dUdT_p
         Q_rev = pybamm.concatenation(
             Q_rev_n, pybamm.FullBroadcast(0, "separator", "current collector"), Q_rev_p
         )