Merge pull request pybamm-team#3905 from pybamm-team/issue-3495-separ…

…ator Issue 3495 separator
agriyakhetarpal · Mar 19, 2024 · 9bf979b · 9bf979b
2 parents 629a7de + 3b6a2df
commit 9bf979b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 
 ## Bug Fixes
 
+- Fixed bug where separator porosity was used in calculation instead of transport efficiency ([#3905](https://github.com/pybamm-team/PyBaMM/pull/3905))
 - Initial voltage can now match upper or lower cut-offs exactly ([#3842](https://github.com/pybamm-team/PyBaMM/pull/3842))
 - Fixed a bug where 1+1D and 2+1D models would not work with voltage or power controlled experiments([#3829](https://github.com/pybamm-team/PyBaMM/pull/3829))
 - Update IDAKLU solver to fail gracefully when a variable is requested that was not in the solves `output_variables` list ([#3803](https://github.com/pybamm-team/PyBaMM/pull/3803))

diff --git a/...bmodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py b/...bmodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py
@@ -78,7 +78,7 @@ def get_coupled_variables(self, variables):
             else:
                 phi_e_n = variables["Negative electrolyte potential [V]"]
                 phi_e_n_s = pybamm.boundary_value(phi_e_n, "right")
-            tor_s = variables["Separator porosity"]
+            tor_s = variables["Separator electrolyte transport efficiency"]
             T = variables["Separator temperature [K]"]
 
             chiRT_over_Fc_e_s = param.chiRT_over_Fc(c_e_s, T)