Add support for redis-py 3+ #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriHeupa
commented
Mar 14, 2019
| @@ -119,7 +116,7 @@ def rank_member_across( | |||
| @param score [float] Member score. | |||
| @param member_data [String] Optional member data. | |||
| ''' | |||
| for leaderboard_name in leaderboards: | |||
| for leaderboard in leaderboards: | |||
There was a problem hiding this comment.
Btw, it also fixes a typo on this function.
clevercricket
approved these changes
Jan 11, 2021
Change ZADD calls to supply keys and values as a dict instead of positional arguments. Update tests to provide member data as string instead of dict, since redis-py 3+ only accepts data as bytes, strings or numbers. Fixes agoragames#61
YuriHeupa
force-pushed
the
add-redis-py-3-support
branch
from
575e082 to
a34e441
Compare
|
Rebased and resolved conflicts. |
|
Could this be packaged in a new version ? Just pip install redis breaks usage of leaderboard |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redis-py 3.X introduced some breaking changes that made this project incompatible, this PR adds support for these changes and fix tests were applicabble. Follows some redis-py changes:
https://github.com/andymccurdy/redis-py#mset-msetnx-and-zadd
https://github.com/andymccurdy/redis-py#encoding-of-user-input
https://github.com/andymccurdy/redis-py#zincrby
So this PR change all ZADD calls to supply keys and values as a dict instead of positional arguments, and it also update tests to provide
member_dataas string instead of dict, as stated in docstring methods, these data should be provided in string already.Fixes #61