Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'zapcore.Level' with more general 'zapcore.LevelEnabler'. #23

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Replace 'zapcore.Level' with more general 'zapcore.LevelEnabler'. #23

merged 4 commits into from
Dec 11, 2024

Conversation

jenshans
Copy link
Contributor

This PR implements and closes #22.

@jenshans jenshans marked this pull request as ready for review November 29, 2024 13:04
chameleon82
chameleon82 reviewed Dec 1, 2024
View reviewed changes
otelzap/otelzap.go Outdated Show resolved Hide resolved
@jenshans jenshans requested a review from chameleon82 December 2, 2024 09:29
@jenshans
Copy link
Contributor Author

jenshans commented Dec 9, 2024

Friendly ping 😊

@chameleon82
Copy link
Collaborator

could you please add test to cover use case with level enabler?

@jenshans
Copy link
Contributor Author

could you please add test to cover use case with level enabler?

Sure! I added a test that illustrates that the log level can be changed after creation of the otlpCore instance.

@chameleon82
Copy link
Collaborator

Thanks for fixing slog test!

@chameleon82 chameleon82 merged commit 63dee5a into agoda-com:main Dec 11, 2024
3 checks passed
@jenshans
Copy link
Contributor Author

Thanks for fixing slog test!

Thanks for the review! 🙏 What's the process for releasing the change?

@chameleon82
Copy link
Collaborator

@jenshans sorry, missed your message.
You can use git-hash from main branch.

also, just released:
https://github.com/agoda-com/opentelemetry-go/releases/tag/otelzap%2Fv0.2.4

Thanks for heads-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebwangsut natebwangsut Awaiting requested review from natebwangsut natebwangsut is a code owner

@chameleon82 chameleon82 Awaiting requested review from chameleon82 chameleon82 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make log level changeable
2 participants
@jenshans @chameleon82