Add bundle size stats #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bundle size for devfeedback
[FIX] use reduce instead of loop
Vedmax
reviewed
Jul 4, 2024
| for (const [fileName, assetInfo] of Object.entries(bundle)) { | ||
| const filePath = path.join(options.dir || '', fileName); | ||
| try { | ||
| const stats = await fs.stat(filePath); |
There was a problem hiding this comment.
How much slower has this plugin become? Did you do any benchmarks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Bundle Size
ViteBuildStatsPlugin
bundleFilesandbundleSizeinviteBuildStatsPlugin.bundleFilesis a record of all files generated from the build process, stored as:key:file namevalue:file size in bytesbundleSizeis the total size of all files contained inbundleFiles.WebpackBuildStatsPlugin
bundleFilesandbundleSizeinWebpackBuildStatsPlugin.bundleFilesis a record of all files generated from the build process, stored as:key:file namevalue:file size in bytesbundleSizeis the total size of all files contained inbundleFiles.Result
Notes
bundleFileswill contain all files such as*.js,*.LICENSE.txt,.css,.svg.Vitemay not be the same as the output from the analyzer because the analyzer gets bundle info from Rollup, but I get it from the actual file in disk withfs.