feat(conventions): near-green idioms build16 oscillated on (hook-annotation + empty-fn)#157
Merged
Conversation
…on before greening
build16 reached the FIRST fully-green autonomous supplier build (done in 167 turns) — but
spent ~40 turns oscillating 1↔5 near-green on two repeated over-annotation/placeholder
habits it eventually self-corrected via the steers. Front-load them so future builds don't:
- data-fetching: the Readable<…> mismatch appears on the HOOK generic too
(UseMutationResult<Readable<…>> vs UseMutationResult<IEntity>), not just the fn return —
leave BOTH the fn and the useQuery/useMutation hook UN-annotated and let TS infer.
- testing: a no-op/placeholder callback must be vi.fn(), never an empty () => {}
(no-empty-function — build16's final blocker was 9 of these in one row-hook test).
Tests updated. Full suite green (2833).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #156. build16 = FIRST fully-green autonomous build (done in 167 turns) but spent ~40 turns oscillating on two self-corrected habits; front-load them: (1) the Readable<…> mismatch also hits the useQuery/useMutation HOOK generic (UseMutationResult vs ), not just the fn return — leave BOTH un-annotated, infer; (2) no-op test callbacks must be vi.fn(), never () => {} (no-empty-function — build16's final blocker: 9 in one row-hook test). Guide + gate-stages steer both updated (consistent), no-empty-function mapped into TOPIC_RULES.testing for reactive push. Panel PASS.