feat(conventions+gate): api-client path/call-shape guide + two-cause PathsWithMethod steer#152
Merged
Merged
Conversation
…PathsWithMethod steer
build12 (i18n active) built the full slice + cleared the dead-key wall, then PARKED
because every colocated test sprayed on generated api-client USAGE errors — panel 4/4:
wrong path (`/api/supplier` vs real `/api/v1/supplier[/{id}]`), PATCH called with 3
args, Readable<SuccessResponse> mistaken for the item. Model reran generate:api 5×
(wrong lever — these are consumer bugs, the route was already in the spec).
- data-fetching guide: verified path format (/api/v1/<resource>[/{id}], literal {id})
and call shapes. Options object is OPTIONAL (plain GET is 1 arg); params+body go in
ONE options object — never a third positional arg (fixes the panel's 'ALWAYS two
args' contradiction). Readable<SuccessResponse> = route response-schema fix.
- gate-stages PathsWithMethod steer: REWRITTEN to name BOTH causes call-site-FIRST
(wrong /api/v1 string vs unregistered route) — the old steer said only 'route not in
spec + generate:api', directly contradicting the guide and mis-steering build12's
wrong-string case. Now consistent front-load + per-error steer.
- tests: method<->shape pairings (not loose fragments); gate-stages test asserts the
two-cause steer + wrong-lever note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on i18n PR. build12 parked: every colocated test sprayed on generated api-client USAGE (path /api/supplier vs /api/v1/…, 3-arg PATCH, Readable); model reran generate:api 5× (wrong lever). data-fetching guide gets verified path format + call shapes; gate-stages PathsWithMethod steer REWRITTEN to name all 3 causes call-site-first (supersedes #149's route-only steer). Panel PASS (4/4).