Make glob a real dependency #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use glob in extract-strings, which is exported for use by consumers, so it should be an actual dependency, not a dev dependency. It could be a peer dependency, but there's no specific reason to require it to be synced with whatever version of `glob` a consumer may be using since it's just a dev tool. While doing this I realized that `npm install` will change `package-lock.json` to use the same indentation style as `package.json`. I missed this when setting up Prettier before, so telling Prettier to ignore `package-lock.json` doesn't actually help. I could send `package.json` back to using spaces, but tabs are preferred for accessibility. I've also run `npm pkg fix` here to address some warnings logged when publishing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use glob in
extract-strings, which is exported for use by consumers, so it should be an actual dependency, not a dev dependency. It could be a peer dependency, but there's no specific reason to require it to be synced with whatever version ofgloba consumer may be using since it's just a dev tool.While doing this I realized that
npm installwill changepackage-lock.jsonto use the same indentation style aspackage.json. I missed this when setting up Prettier before, so telling Prettier to ignorepackage-lock.jsondoesn't actually help. I could sendpackage.jsonback to using spaces, but tabs are preferred for accessibility.I've also run
npm pkg fixhere to address some warnings logged when publishing.