Upgrade packages and add Prettier #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCKcode
approved these changes
Dec 14, 2023
I upgraded as many packages as I could without causing issues I couldn't fix. We'll probably want to switch from Mocha to Jest if we keep this package around much longer.
Everyone uses Prettier now and the only setting we tweak is to use tabs. The actual formatting will be in the next commit. This one should fail the updated CI script.
Self-explanatory, ran `npm run prettier`
|
I'm good with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded as many packages as I could without causing issues I couldn't fix. We'll probably want to switch from Mocha to Jest if we keep this package around much longer.
I also added Prettier, including to the build-and-test GitHub action, then added a commit that formats everything. You can see below that the action failed when it was added and passed when the formatting commit was added.
Because the formatting is a large diff that doesn't need to be reviewed, I recommend reviewing this PR one commit at a time.