preserve comments with AST #80
Merged
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I do still think modifying the output file by addressing line numbers and only changing what is new is a more sustainable solution, but this gets us back up and running in the meantime. |
tcdent
approved these changes
Dec 3, 2024
Contributor
Author
totally agreed. in my mind i wanted a hot fix to address #74 which has been reported too many times |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #77 i noticed that adding an agent failed because the
# Agent definitionstag had disappeared after the file was modified with AST.This is a simple fix that records comments in the original and inserts them while arranging the file via AST