Remove tools.json #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboynton97
reviewed
Nov 27, 2024
Contributor
|
we also need to update the logic for |
….9 compatibility with package paths in tool_generation. Standardize naming in tool json configs.
Collaborator
Author
|
Just took care of #26 as well. I'll stop throwing stuff into this PR now 😇 |
tcdent
commented
Nov 28, 2024
Contributor
|
it looks like the github workflow is only testing 3.11 and 3.12. ill make a pr to fix this. but 3.9 is still failing with tox when checked out. i'm okay with removing support for 3.9 if we see a good reason |
# Conflicts: # agentstack/tools/tools.json
bboynton97
approved these changes
Nov 30, 2024
Contributor
|
merged main in, updated great idea @tcdent on testing all the tool files! i was going to add that in a separate PR then saw you did it here 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #57