Skip to content

Conversation

@tcdent
Copy link
Collaborator

@tcdent tcdent commented Nov 14, 2024

remove_tool will delete the tool's py file, remove it from imports and instruct the user to uninstall dependencies.

It does not delete the .env variables, since I thought we might not want to delete user data.

Verifies that a tool is installed before removing, and verifies it is not installed before adding.

Also removed the code for add_tool_to_agent_definition since it looks like that's covered by decorators now.

@bboynton97
Copy link
Contributor

This is incredible! Thank you for the contribution. A few notes:

It looks like agentstack tools add <name> isnt adding the tools to the agents in crew.py

It might be a great idea to change package from poetry add <package> to just a list of packages and then we can dynamically add poetry add and poetry remove based on which operation.

@tcdent
Copy link
Collaborator Author

tcdent commented Nov 15, 2024

I see that now; I didn't have an agent defined in my test installation and hadn't dug far enough into the code to fully understand that.

Add/remove from the agents in crew.py is now implemented.

@tcdent
Copy link
Collaborator Author

tcdent commented Nov 15, 2024

Now supports poetry add and poetry remove from a list of packages in the tool JSON files.

@tcdent
Copy link
Collaborator Author

tcdent commented Nov 15, 2024

check, check, check 😎

@bboynton97
Copy link
Contributor

those last few nits on crewai-tools and this look golden 🙌

@tcdent
Copy link
Collaborator Author

tcdent commented Nov 15, 2024

crewai-tools is in the pyproject.toml for the codegen agent project, so if it's in the JSON as well, it gets uninstalled and breaks the dependency graph

https://github.com/AgentOps-AI/AgentStack/blob/2ebaa93d9e00466983889ac7c41a774f58f52aaa/agentstack/templates/crewai/%7B%7Bcookiecutter.project_metadata.project_slug%7D%7D/pyproject.toml#L12

@bboynton97
Copy link
Contributor

i see! okay then i like it as is. I'll resolve the comments and this looks good to go!

Copy link
Contributor

@bboynton97 bboynton97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely great work 🙏

@bboynton97 bboynton97 merged commit 9694ab5 into agentstack-ai:main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants