Skip to content

Conversation

@dhanushreddy291
Copy link
Contributor

Should fix #253

@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@tcdent
Copy link
Collaborator

tcdent commented Jan 30, 2025

agentstack/generation/tool_generation.py:22: error: Argument 1 to "install" has incompatible type "list[str]"; expected "str"  [arg-type]

packaging.install expects a string, so you'll need to iterate over the dependencies when passing them individually.

@dhanushreddy291
Copy link
Contributor Author

dhanushreddy291 commented Jan 30, 2025

agentstack/generation/tool_generation.py:22: error: Argument 1 to "install" has incompatible type "list[str]"; expected "str"  [arg-type]

packaging.install expects a string, so you'll need to iterate over the dependencies when passing them individually.

updated @tcdent

Copy link
Collaborator

@tcdent tcdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this fixes the bug.

@tcdent tcdent merged commit afe916b into agentstack-ai:main Jan 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Tool installation fails when they have multiple dependencies

2 participants