Skip to content

Make .env file parser more robust #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tcdent merged 1 commit into from
Jan 28, 2025
Merged

Make .env file parser more robust #246

tcdent merged 1 commit into from
Jan 28, 2025

Conversation

@tcdent
Copy link
Collaborator

@tcdent tcdent commented Jan 28, 2025 •
edited
Loading

Resolves #232

@tcdent tcdent changed the title Make .env file parser more robust. Resolves #232. Make .env file parser more robust Jan 28, 2025
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentstack/generation/files.py 71.42% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

bboynton97
bboynton97 reviewed Jan 28, 2025
View reviewed changes
@bboynton97
Copy link
Contributor

bboynton97 commented Jan 28, 2025

I had to use claude to explain the regex to me but it looks golden 🙂‍↕️

@tcdent
Copy link
Collaborator Author

tcdent commented Jan 28, 2025

Claude wrote the regex lol

@tcdent tcdent merged commit 49033de into agentstack-ai:main Jan 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bboynton97 bboynton97 bboynton97 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] Parsing .env file entries with "=" in the value results in an error

2 participants

@tcdent @bboynton97